Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(core): add undecorated classes with decorated fields schematic #32130

Closed
wants to merge 2 commits into from
Closed

feat(core): add undecorated classes with decorated fields schematic #32130

wants to merge 2 commits into from

Conversation

crisbeto
Copy link
Member

@crisbeto crisbeto commented Aug 14, 2019 •
edited

Adds a schematic that adds a Directive decorator to undecorated classes that have fields that use Angular decorators.

@crisbeto crisbeto added action: review The PR is still awaiting reviews from at least one requested reviewer state: blocked target: major This PR is targeted for the next major release labels Aug 14, 2019
@crisbeto crisbeto marked this pull request as ready for review August 14, 2019 08:21
@crisbeto crisbeto requested a review from a team as a code owner August 14, 2019 08:21
@crisbeto
Copy link
Member Author

Updated to address the feedback. Also no longer blocked.

@kara kara added action: cleanup The PR is in need of cleanup, either due to needing a rebase or in response to comments from reviews and removed cla: yes labels Aug 17, 2019
@kara kara added area: core Issues related to the framework runtime and removed cla: yes labels Aug 17, 2019
@ngbot ngbot bot modified the milestone: needsTriage Aug 17, 2019
@kara kara requested a review from alxhub August 17, 2019 22:49
@crisbeto crisbeto removed the action: cleanup The PR is in need of cleanup, either due to needing a rebase or in response to comments from reviews label Aug 19, 2019
@crisbeto crisbeto removed their assignment Aug 19, 2019
@crisbeto
Copy link
Member Author

The feedback has been addressed @kara.

@crisbeto
feat(core): add undecorated classes with decorated fields schematic
ea939d8 
Adds a schematic that adds a `Directive` decorator to undecorated classes that have fields that use Angular decorators.
kara
kara approved these changes Aug 21, 2019
View reviewed changes
Copy link
Contributor

@kara kara left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, one more comment to fix though (and CI looks unhappy?)

packages/core/schematics/migrations/google3/undecoratedClassesWithDecoratedFieldsRule.ts Outdated Show resolved Hide resolved
@crisbeto
Copy link
Member Author

Addressed the last set of feedback and pushed something to fix the CI.

@kara kara added action: merge The PR is ready for merge by the caretaker action: presubmit The PR is in need of a google3 presubmit and removed action: review The PR is still awaiting reviews from at least one requested reviewer labels Aug 22, 2019
@kara
Copy link
Contributor

kara commented Aug 22, 2019

VE presubmit

Ivy presubmit

@atscott atscott removed the action: presubmit The PR is in need of a google3 presubmit label Aug 22, 2019
@atscott atscott closed this in 904a201 Aug 22, 2019
ngdevelop-tech pushed a commit to ngdevelop-tech/angular that referenced this pull request Aug 27, 2019
@crisbeto @ngdevelop-tech
feat(core): add undecorated classes with decorated fields schematic (a…
39de7b9 
…ngular#32130)

Adds a schematic that adds a `Directive` decorator to undecorated classes that have fields that use Angular decorators.

PR Close angular#32130
sabeersulaiman pushed a commit to sabeersulaiman/angular that referenced this pull request Sep 6, 2019
@crisbeto @sabeersulaiman
feat(core): add undecorated classes with decorated fields schematic (a…
237b0a3 
…ngular#32130)

Adds a schematic that adds a `Directive` decorator to undecorated classes that have fields that use Angular decorators.

PR Close angular#32130
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 22, 2019
arnehoek pushed a commit to arnehoek/angular that referenced this pull request Sep 26, 2019
@crisbeto @arnehoek
feat(core): add undecorated classes with decorated fields schematic (a…
8943bcf 
…ngular#32130)

Adds a schematic that adds a `Directive` decorator to undecorated classes that have fields that use Angular decorators.

PR Close angular#32130
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@devversion devversion devversion left review comments

@alan-agius4 alan-agius4 alan-agius4 left review comments

@kara kara kara approved these changes

@alxhub alxhub alxhub approved these changes

Assignees
No one assigned
Labels
action: merge The PR is ready for merge by the caretaker area: core Issues related to the framework runtime cla: yes target: major This PR is targeted for the next major release
Projects
None yet
Milestone
needsTriage
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@crisbeto @kara @alxhub @devversion @alan-agius4 @atscott @googlebot